[pull] androidx-main from androidx:androidx-main #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid calling setTorchAsync(false) in TorchControl.reset() if the torch mode has not been set before. This avoids a small amount of redundant work and, more importantly, prevents unnecessary error logs in scenarios where the camera is being reset or closed multiple times quickly. Such error logs may be flagged as unexpected error logs and lead to test failures in some strict environments, this CL addresses such issues properly. Bug: 475380959 Test: ./gradlew 📷camera-camera2:test Change-Id: I56d3dafcee8c1b9c97cfe7cace67b69d796eeaa8
The AnnotationSelectionTouchHandler was incorrectly returning after evaluating only the first path object of an annotation. This caused the Object Eraser to fail when a touch intersected any part of the highlight other than its initial path object. This change ensures that all path objects within an annotation are checked for intersection with the touch region, allowing the eraser to function correctly across the entire highlight. Bug: 475101877 Test: ./gradlew :pdf:integration-tests:connectedAndroidTest Change-Id: Ib0623439a5d37c482546f44c228894581b3b63ae
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )